chadrik commented on a change in pull request #13060:
URL: https://github.com/apache/beam/pull/13060#discussion_r505932577
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -355,9 +361,9 @@ def _run_bundle_multiple_times_for_testing(
self,
runner_execution_context, # type: execution.FnApiRunnerExecutionContext
bundle_manager, # type: BundleManager
- data_input,
+ data_input, # type: Dict[str, PartitionableBuffer]
data_output, # type: DataOutput
- fired_timers,
+ fired_timers, # type: Mapping[Tuple[str, str],
execution.PartitionableBuffer]
Review comment:
note to self: standardize on `PartitionableBuffer` vs
`execution.PartitionableBuffer`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
