chadrik commented on a change in pull request #13060:
URL: https://github.com/apache/beam/pull/13060#discussion_r506776533
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py
##########
@@ -227,12 +251,24 @@ def __iter__(self):
"""
return itertools.chain(*self.partition(1))
+ # these should never be accessed, but they allow this class to meet the
Review comment:
I prefer the current solution because it's reasonable and safe to call
`clear()` and `reset()` on this class and have it do nothing: there's simply
nothing to clear or reset. It seems wrong to meet the protocol definition,
but then error if the methods are called: that's not really meeting the
protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
