youngoli commented on pull request #13255: URL: https://github.com/apache/beam/pull/13255#issuecomment-722125473
Actually don't merge this yet. I ran into an issue where adding a scope (i.e. putting the external transform in a composite) causes all the examples to fail. It seems to be because of a built-in assumption in the cross-language code that the root transform of the protobuf external transform is the external transform itself, but this is false when it's in a composite, because the root transform is the composite instead. I'm still trying to fix that, because this is an issue that would give users trouble immediately and needs to be fixed ASAP. That said, if the rest of the PR looks good I might just comment out the Scope calls with a TODO and a Jira, since that will work. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
