lostluck commented on a change in pull request #13255:
URL: https://github.com/apache/beam/pull/13255#discussion_r519067725
##########
File path: sdks/go/pkg/beam/core/runtime/xlangx/expand.go
##########
@@ -20,25 +20,40 @@ import (
"github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
jobpb "github.com/apache/beam/sdks/go/pkg/beam/model/jobmanagement_v1"
+ "github.com/apache/beam/sdks/go/pkg/beam/model/pipeline_v1"
Review comment:
Please abbreviate the pipeline_v1 package protos as pipepb.
##########
File path: sdks/go/pkg/beam/core/runtime/xlangx/expand.go
##########
@@ -20,25 +20,40 @@ import (
"github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
jobpb "github.com/apache/beam/sdks/go/pkg/beam/model/jobmanagement_v1"
+ "github.com/apache/beam/sdks/go/pkg/beam/model/pipeline_v1"
"google.golang.org/grpc"
)
// Expand queries the expansion service to resolve the ExpansionRequest
Review comment:
We might want to expand the description here, since the expansion
request is being created "in house".
// Expand submits the pipeline components and root transform to be expanded
by the given expansion service.
//
// Most should call beam.CrossLanguage to access foreign transforms rather
than calling this function directly.
The latter segment is probably unnecessary since it won't add things to the
pipeline properly.. but we don't currently have too much documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
