amaliujia edited a comment on pull request #13306: URL: https://github.com/apache/beam/pull/13306#issuecomment-726553782
If we don't expose CombineFn in interface, I think what we will end is a similar interface design to current CombineFn: we will ask users to offer implementations `init accumulator`, `add input`, `merge accumulator`, `extract`, etc. then in implementation we will create CombineFn wrapper. The benefits for this decoupling seems little given CombineFn is a stable API in Beam. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
