amaliujia edited a comment on pull request #13306:
URL: https://github.com/apache/beam/pull/13306#issuecomment-729440157


   I am not sure if I have understand: 
   >One example is that a UDAF has to have a SQL
   
   This interface is the implementation interface of a UDAF, but not  function 
definition. Function definition should provide SQL types, but definition in our 
case is the CREATE FUNCTION statement.
   
   
   >A decoupled interface and trivial wrapper have obvious benefits and no real 
downside.
   
   I don't agree in this case that creating a wrapper is trivial. For 
UDAF/CombeFn, I think it is non-trival work to create the wrapper.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to