davidyan74 commented on a change in pull request #13335:
URL: https://github.com/apache/beam/pull/13335#discussion_r528883529
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -504,10 +504,12 @@ def run(self, test_runner_api='AUTO'):
if test_runner_api == 'AUTO':
# Don't pay the cost of a round-trip if we're going to be going through
# the FnApi anyway...
+ # The InteractiveRunner relies a constant pipeline reference, skip it.
Review comment:
nit: relies -> relies on
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -504,10 +504,12 @@ def run(self, test_runner_api='AUTO'):
if test_runner_api == 'AUTO':
# Don't pay the cost of a round-trip if we're going to be going through
# the FnApi anyway...
+ # The InteractiveRunner relies a constant pipeline reference, skip it.
test_runner_api = (
not self.runner.is_fnapi_compatible() and (
self.runner.__class__.__name__ != 'SwitchingDirectRunner' or
- self._options.view_as(StandardOptions).streaming))
+ self._options.view_as(StandardOptions).streaming) and
+ self.runner.__class__.__name__ != 'InteractiveRunner')
Review comment:
Is there a better way for the runner to indicate it relies on a constant
pipeline reference?
##########
File path: sdks/python/apache_beam/runners/interactive/background_caching_job.py
##########
@@ -121,7 +121,8 @@ def state(self):
return self._pipeline_result.state
-def attempt_to_run_background_caching_job(runner, user_pipeline, options=None):
+def attempt_to_run_background_caching_job(
Review comment:
Should we take this opportunity to update the name according to the new
convention? e.g. "background caching job" -> "background source recording job".
It's fine if you plan to do this in a later PR instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
