rohdesamuel commented on a change in pull request #13335:
URL: https://github.com/apache/beam/pull/13335#discussion_r529855458
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -504,10 +504,12 @@ def run(self, test_runner_api='AUTO'):
if test_runner_api == 'AUTO':
# Don't pay the cost of a round-trip if we're going to be going through
# the FnApi anyway...
+ # The InteractiveRunner relies a constant pipeline reference, skip it.
test_runner_api = (
not self.runner.is_fnapi_compatible() and (
self.runner.__class__.__name__ != 'SwitchingDirectRunner' or
- self._options.view_as(StandardOptions).streaming))
+ self._options.view_as(StandardOptions).streaming) and
+ self.runner.__class__.__name__ != 'InteractiveRunner')
Review comment:
@TheNeuralBit what do you think? I was following the precedence of the
SwitchingDirectRunner. The InteractiveRunner already does this check in its
code in multiple places, so there wouldn't be a safety regression if this line
is added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
