TheNeuralBit commented on a change in pull request #13410:
URL: https://github.com/apache/beam/pull/13410#discussion_r529153011
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/JulHandlerPrintStreamAdapterFactory.java
##########
@@ -86,7 +86,7 @@ public void write(int i) throws IOException {
this.logger = Logger.getLogger(loggerName);
this.buffer = new StringBuilder();
this.decoder =
- Charset.defaultCharset()
+ StandardCharsets.UTF_8
Review comment:
@scwhittle I was wondering if you could comment on this since you added
this line in https://github.com/apache/beam/pull/11096. Do you know if this
change is safe? Is there a reason this needs to use `defaultCharset`?
As it is, `testLogRawBytes` below can fail if the system encoding isn't UTF-8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
