scwhittle commented on a change in pull request #13410:
URL: https://github.com/apache/beam/pull/13410#discussion_r529905037
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/JulHandlerPrintStreamAdapterFactory.java
##########
@@ -86,7 +86,7 @@ public void write(int i) throws IOException {
this.logger = Logger.getLogger(loggerName);
this.buffer = new StringBuilder();
this.decoder =
- Charset.defaultCharset()
+ StandardCharsets.UTF_8
Review comment:
This class is going to be used to replace the default
System.out/System.err which appears to be specified to use the default charset.
So it seems better to keep it consistent IMO to avoid surprises when someone
expects that charset writing to System.out, not UTF-8. If the test is
incorrect, it should be fixed (by examining or setting the defaultCharset)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
