dpmills commented on a change in pull request #13429:
URL: https://github.com/apache/beam/pull/13429#discussion_r530659752
##########
File path: sdks/python/apache_beam/metrics/cells.py
##########
@@ -77,6 +79,13 @@ def reset(self):
# type: () -> None
raise NotImplementedError
+ @property
+ def start_time(self):
Review comment:
Could simplify this a bit by putting the start time logic in
MetricCell.to_runner_api_monitoring_info and having that call a
to_runner_api_monitoring_info_impl on each of the subclasses
##########
File path: model/pipeline/src/main/proto/metrics.proto
##########
@@ -401,6 +402,17 @@ message MonitoringInfo {
// as Stackdriver will be able to aggregate the metrics using a subset of the
// provided labels
map<string, string> labels = 4;
+
+ // This indicates when the first value was populated by the SDK Harness.
Review comment:
Maybe "This indicates the start of the time range over which this value
was measured"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
