dpmills commented on a change in pull request #13429:
URL: https://github.com/apache/beam/pull/13429#discussion_r533844127
##########
File path: sdks/python/apache_beam/metrics/cells.py
##########
@@ -77,6 +79,13 @@ def reset(self):
# type: () -> None
raise NotImplementedError
+ @property
+ def start_time(self):
Review comment:
Something like this:
class MetricCell:
def to_runner_api_monitoring_info(self, name, transform_id):
mi = self.to_runner_api_monitoring_info_impl(name, transform_id)
mi.start_time.FromDatetime(self.start_time) # or just put the start_time
code inline here
return mi
Then, rename all the to_runner_api_monitoring_info methods in the subclasses
to to_runner_api_monitoring_info_impl
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
