kennknowles commented on a change in pull request #13690:
URL: https://github.com/apache/beam/pull/13690#discussion_r555271950



##########
File path: 
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -855,9 +855,11 @@ class BeamModulePlugin implements Plugin<Project> {
       // configurations because they are never required to be shaded or become 
a
       // dependency of the output.
       def compileOnlyAnnotationDeps = [
-        "com.google.auto.value:auto-value-annotations:1.7",
+        "com.google.auto.value:auto-value-annotations:1.7.2",
         "com.google.auto.service:auto-service-annotations:1.0-rc6",
         "com.google.j2objc:j2objc-annotations:1.3",
+        "org.checkerframework:checker-qual:3.7.0",

Review comment:
       These annotations do end up in the class files so users can benefit from 
them.
   
   Java spec is that annotations that cannot be resolved on the classpath 
should be ignored. Unfortunately, the JDK has a bug (don't recall if/when it 
was fixed) where it actually causes a crash.
   
   See https://github.com/apache/beam/pull/13169 and 
https://issues.apache.org/jira/browse/BEAM-10632




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to