sonam-vend commented on a change in pull request #13690:
URL: https://github.com/apache/beam/pull/13690#discussion_r555296677



##########
File path: 
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -855,9 +855,11 @@ class BeamModulePlugin implements Plugin<Project> {
       // configurations because they are never required to be shaded or become 
a
       // dependency of the output.
       def compileOnlyAnnotationDeps = [
-        "com.google.auto.value:auto-value-annotations:1.7",
+        "com.google.auto.value:auto-value-annotations:1.7.2",
         "com.google.auto.service:auto-service-annotations:1.0-rc6",
         "com.google.j2objc:j2objc-annotations:1.3",
+        "org.checkerframework:checker-qual:3.7.0",

Review comment:
       @kennknowles If I understood your point correctly, you mean to remove 
checker-qual from compileOnlyAnnotationDeps,
   
   and add here like,
    ```
   // Disregard unused but declared (test) compile only dependencies used
         // for common annotation classes used during compilation such as 
annotation
         // processing or post validation such as spotbugs.
         project.dependencies {
           compileOnlyAnnotationDeps.each { dep ->
             permitUnusedDeclared dep
             permitTestUnusedDeclared dep
           }
           **permitUnusedDeclared 
"org.checkerframework:checker-qual:$checkerframework_version"**
         }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to