lostluck commented on a change in pull request #13434:
URL: https://github.com/apache/beam/pull/13434#discussion_r556711306



##########
File path: sdks/go/pkg/beam/pardo_test.go
##########
@@ -61,3 +71,65 @@ func TestFormatParDoError(t *testing.T) {
                t.Errorf("formatParDoError(testFunction,2,1) = %v, want = %v", 
got, want)
        }
 }
+
+func TestAnnotations(t *testing.T) {
+       m := make(map[string][]byte)
+       m["privacy_property"] = []byte("differential_privacy")
+       doFn := &AnnotationsFn{Annotations: m}
+
+       p := NewPipeline()
+       s := p.Root()
+
+       values := [2]int{0, 1}
+       col := CreateList(s, values)

Review comment:
       Consider using an Impulse instead, which simplifies the pipe to just the 
2 transforms. The element would then be input `_ []byte` since impulse is 
traditionally ignored.)
   
   However, I'm not going to worry about it at this juncture, since it would 
not meaningfully shrink the PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to