aaltay commented on a change in pull request #13740:
URL: https://github.com/apache/beam/pull/13740#discussion_r558559746



##########
File path: 
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -435,7 +443,7 @@ class BeamModulePlugin implements Plugin<Project> {
     def google_oauth_clients_version = "1.31.0"
     // Try to keep grpc_version consistent with gRPC version in 
google_cloud_platform_libraries_bom
     def grpc_version = "1.32.2"
-    def guava_version = "25.1-jre"
+    def guava_version = guava25Projects.contains(project.path) ? "25.1-jre" : 
"30.1-jre"

Review comment:
       Ack. I think this would be an undocumented hurdle for the impacted 
users. I am not sure what is the best course of action. Hopefully @kennknowles 
would have a recommendation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to