suztomo commented on a change in pull request #13740:
URL: https://github.com/apache/beam/pull/13740#discussion_r558782709



##########
File path: 
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -435,7 +443,7 @@ class BeamModulePlugin implements Plugin<Project> {
     def google_oauth_clients_version = "1.31.0"
     // Try to keep grpc_version consistent with gRPC version in 
google_cloud_platform_libraries_bom
     def grpc_version = "1.32.2"
-    def guava_version = "25.1-jre"
+    def guava_version = guava25Projects.contains(project.path) ? "25.1-jre" : 
"30.1-jre"

Review comment:
       Yes, I think I should document that condition ("_if Beam Cassandra / 
Hadoop users use Beam with beam-sdks-java-io-kinesis, ..._") somewhere.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to