kennknowles commented on a change in pull request #13660:
URL: https://github.com/apache/beam/pull/13660#discussion_r561196826
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -78,18 +79,25 @@ dependencies {
compile library.java.google_api_client
compile library.java.google_api_services_clouddebugger
compile library.java.google_api_services_dataflow
- compile library.java.google_api_services_storage
+ testImplementation
'com.google.apis:google-api-services-storage:v1-rev20200611-1.30.10'
Review comment:
1. This should be `library.java. google_api_services_dataflow`
2. The version should be provided by the GCP Libraries BOM
@kileys yes?
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -78,18 +79,25 @@ dependencies {
compile library.java.google_api_client
compile library.java.google_api_services_clouddebugger
compile library.java.google_api_services_dataflow
- compile library.java.google_api_services_storage
+ testImplementation
'com.google.apis:google-api-services-storage:v1-rev20200611-1.30.10'
compile library.java.google_auth_library_credentials
compile library.java.google_auth_library_oauth2_http
compile library.java.google_http_client
- compile library.java.google_http_client_jackson2
+ testImplementation
'com.google.http-client:google-http-client-jackson2:1.34.0'
compile library.java.jackson_annotations
compile library.java.jackson_core
compile library.java.jackson_databind
compile library.java.joda_time
compile library.java.slf4j_api
compile library.java.vendored_grpc_1_26_0
- testCompile library.java.hamcrest_core
+ compile "org.checkerframework:checker-qual:2.0.0"
Review comment:
This one will be handled by BeamModulePlugin, so delete
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -78,18 +79,25 @@ dependencies {
compile library.java.google_api_client
compile library.java.google_api_services_clouddebugger
compile library.java.google_api_services_dataflow
- compile library.java.google_api_services_storage
+ testImplementation
'com.google.apis:google-api-services-storage:v1-rev20200611-1.30.10'
compile library.java.google_auth_library_credentials
compile library.java.google_auth_library_oauth2_http
compile library.java.google_http_client
- compile library.java.google_http_client_jackson2
+ testImplementation
'com.google.http-client:google-http-client-jackson2:1.34.0'
Review comment:
This should be `library.java.google_http_client_jackson2`
For each dependency, please find it in this list:
https://github.com/apache/beam/blob/b131cc88c85cde646514ba7f0385e1b5f768ae0d/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L463
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
