ibzib commented on a change in pull request #13666:
URL: https://github.com/apache/beam/pull/13666#discussion_r561204924
##########
File path: runners/portability/java/build.gradle
##########
@@ -32,12 +32,19 @@ configurations {
dependencies {
compile library.java.vendored_guava_26_0_jre
- compile library.java.hamcrest_library
compile project(":runners:java-fn-execution")
compile project(":runners:java-job-service")
compile project(path: ":sdks:java:harness", configuration: "shadow")
compile library.java.vendored_grpc_1_26_0
compile library.java.slf4j_api
+ compile library.java.joda_time
+ compile "org.hamcrest:hamcrest:2.1"
Review comment:
Test code should not be present on the main classpath. Follow-up:
BEAM-11668 (not a blocker for this PR)
##########
File path: runners/portability/java/build.gradle
##########
@@ -19,7 +19,7 @@ import groovy.json.JsonOutput
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature(automaticModuleName: 'org.apache.beam.runners.portability')
+applyJavaNature(enableStrictDependencies:true, automaticModuleName:
'org.apache.beam.runners.portability')
Review comment:
Nit: add space
```suggestion
applyJavaNature(enableStrictDependencies: true, automaticModuleName:
'org.apache.beam.runners.portability')
```
##########
File path: runners/portability/java/build.gradle
##########
@@ -32,12 +32,19 @@ configurations {
dependencies {
compile library.java.vendored_guava_26_0_jre
- compile library.java.hamcrest_library
compile project(":runners:java-fn-execution")
compile project(":runners:java-job-service")
compile project(path: ":sdks:java:harness", configuration: "shadow")
compile library.java.vendored_grpc_1_26_0
compile library.java.slf4j_api
+ compile library.java.joda_time
+ compile "org.hamcrest:hamcrest:2.1"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(":runners:core-construction-java")
+ permitUsedUndeclared project(":sdks:java:core")
Review comment:
I'm getting that same error you got if I remove this line:
```
> No signature of method:
ca.cutterslade.gradle.analyze.AnalyzeDependenciesTask$_action_closure3$_closure8.doCall()
is applicable for argument types:
(org.gradle.api.internal.artifacts.PreResolvedResolvableArtifact) values:
[beam-sdks-java-core.jar (project :sdks:java:core)]
Possible solutions: findAll(), findAll(), isCase(java.lang.Object),
isCase(java.lang.Object)
```
I wonder if the plugin has a bug with handling diamond dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
