ibzib commented on a change in pull request #13666:
URL: https://github.com/apache/beam/pull/13666#discussion_r562112899
##########
File path: runners/portability/java/build.gradle
##########
@@ -32,12 +32,19 @@ configurations {
dependencies {
compile library.java.vendored_guava_26_0_jre
- compile library.java.hamcrest_library
compile project(":runners:java-fn-execution")
compile project(":runners:java-job-service")
compile project(path: ":sdks:java:harness", configuration: "shadow")
compile library.java.vendored_grpc_1_26_0
compile library.java.slf4j_api
+ compile library.java.joda_time
+ compile "org.hamcrest:hamcrest:2.1"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(":runners:core-construction-java")
+ permitUsedUndeclared project(":sdks:java:core")
Review comment:
https://github.com/wfhartford/gradle-dependency-analyze/issues/125
##########
File path: runners/portability/java/build.gradle
##########
@@ -32,12 +32,19 @@ configurations {
dependencies {
compile library.java.vendored_guava_26_0_jre
- compile library.java.hamcrest_library
compile project(":runners:java-fn-execution")
compile project(":runners:java-job-service")
compile project(path: ":sdks:java:harness", configuration: "shadow")
compile library.java.vendored_grpc_1_26_0
compile library.java.slf4j_api
+ compile library.java.joda_time
+ compile "org.hamcrest:hamcrest:2.1"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(":runners:core-construction-java")
+ permitUsedUndeclared project(":sdks:java:core")
Review comment:
Anyway, why can't we just declare this one?
```suggestion
compile project(path: ":sdks:java:core", configuration: "shadow")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
