ibzib commented on a change in pull request #13800:
URL: https://github.com/apache/beam/pull/13800#discussion_r564201796
##########
File path: sdks/java/io/snowflake/build.gradle
##########
@@ -27,19 +28,17 @@ ext.summary = "IO to read and write on Snowflake."
dependencies {
compile library.java.vendored_guava_26_0_jre
compile project(path: ":sdks:java:core", configuration: "shadow")
- compile project(path: ":sdks:java:extensions:google-cloud-platform-core")
Review comment:
All of the other changes look good, however I am suspicious of this one.
@tysonjh can you find a reviewer who knows more about Snowflake IO to look at
this?
##########
File path: sdks/java/io/snowflake/build.gradle
##########
@@ -27,19 +28,17 @@ ext.summary = "IO to read and write on Snowflake."
dependencies {
compile library.java.vendored_guava_26_0_jre
compile project(path: ":sdks:java:core", configuration: "shadow")
- compile project(path: ":sdks:java:extensions:google-cloud-platform-core")
Review comment:
All of the other changes look good, however I am suspicious of this
line. @tysonjh can you find a reviewer who knows more about Snowflake IO to
look at this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
