ibzib commented on a change in pull request #13800:
URL: https://github.com/apache/beam/pull/13800#discussion_r568191648
##########
File path: sdks/java/io/snowflake/expansion-service/build.gradle
##########
@@ -32,8 +32,8 @@ description = "Apache Beam :: SDKs :: Java :: IO :: Snowflake
::Expansion Servic
ext.summary = "Expansion service serving Snowflake IO"
dependencies {
- compile project(":sdks:java:expansion-service")
- compile project(":sdks:java:io:snowflake")
+ runtimeOnly project(":sdks:java:expansion-service")
Review comment:
Let's just leave these as compile + permitUnusedDeclared to be safe.
##########
File path: sdks/java/io/snowflake/build.gradle
##########
@@ -27,19 +28,17 @@ ext.summary = "IO to read and write on Snowflake."
dependencies {
compile library.java.vendored_guava_26_0_jre
compile project(path: ":sdks:java:core", configuration: "shadow")
- compile project(path: ":sdks:java:extensions:google-cloud-platform-core")
Review comment:
On second thought, let's just leave this as compile +
permitUnusedDeclared to be safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
