udim commented on a change in pull request #13812:
URL: https://github.com/apache/beam/pull/13812#discussion_r564949112
##########
File path: sdks/python/apache_beam/coders/coder_impl.py
##########
@@ -336,18 +336,18 @@ def __init__(self, proto_message_type):
self.proto_message_type = proto_message_type
def encode(self, value):
- return value.SerializeToString()
+ return value.SerializePartialToString()
def decode(self, encoded):
proto_message = self.proto_message_type()
- proto_message.ParseFromString(encoded)
+ proto_message.ParseFromString(encoded) # This is in effect "ParsePartial".
Review comment:
This comment is saying that this method can parse both initialized and
partial messages. (there is no ParsePartialFromString)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
