udim commented on a change in pull request #13812:
URL: https://github.com/apache/beam/pull/13812#discussion_r564957148
##########
File path: sdks/python/apache_beam/coders/coders_test_common.py
##########
@@ -129,12 +159,20 @@ def test_custom_coder(self):
(-10, b'b'), (5, b'c'))
def test_pickle_coder(self):
- self.check_coder(coders.PickleCoder(), 'a', 1, 1.5, (1, 2, 3))
+ coder = coders.PickleCoder()
+ self.check_coder(coder, *self.values)
def test_deterministic_coder(self):
coder = coders.FastPrimitivesCoder()
deterministic_coder = coders.DeterministicFastPrimitivesCoder(coder,
'step')
- self.check_coder(deterministic_coder, 'a', 1, 1.5, (1, 2, 3))
+ self.check_coder(deterministic_coder, *self.values_deterministic)
+ for v in self.values_deterministic:
+ self.check_coder(coders.TupleCoder((deterministic_coder, )), (v, ))
Review comment:
The coverage is mainly for TupleCoder I believe? I don't know the
reasoning but I wanted to stay consistent with the other tests in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
