shehzaadn-vd commented on a change in pull request #13791:
URL: https://github.com/apache/beam/pull/13791#discussion_r565746976
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -50,50 +50,54 @@ dependencies {
exclude group: 'io.grpc', module: 'grpc-grpclb'
}
compile library.java.google_cloud_core
- compile(library.java.google_cloud_core_grpc) {
- exclude group: 'io.grpc', module: 'grpc-core' // Use Beam's version
- }
compile library.java.google_cloud_datastore_v1_proto_client
compile library.java.google_cloud_pubsublite
// GCP PubSub client is used in TestPubSub
compile library.java.google_cloud_pubsub
compile library.java.google_cloud_spanner
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
- compile library.java.grpc_alts
compile library.java.grpc_auth
- compile library.java.grpc_core
- compile library.java.grpc_context
- compile library.java.grpc_grpclb
+ testImplementation 'io.grpc:grpc-core:1.27.2'
compile library.java.grpc_netty
- compile library.java.grpc_netty_shaded
- compile library.java.grpc_stub
compile library.java.grpc_google_cloud_pubsub_v1
- compile library.java.grpc_google_cloud_pubsublite_v1
compile library.java.guava
- compile library.java.hamcrest_core
compile library.java.jackson_databind
compile library.java.joda_time
compile library.java.junit
compile library.java.netty_handler
- compile library.java.netty_tcnative_boringssl_static
- compile library.java.proto_google_cloud_bigquery_storage_v1beta1
compile library.java.proto_google_cloud_bigtable_v2
compile library.java.proto_google_cloud_datastore_v1
compile library.java.proto_google_cloud_pubsub_v1
compile library.java.proto_google_cloud_pubsublite_v1
- compile library.java.proto_google_cloud_spanner_admin_database_v1
compile library.java.proto_google_common_protos
compile library.java.protobuf_java
compile library.java.slf4j_api
+ compile "com.google.api.grpc:proto-google-cloud-bigquerystorage-v1:0.90.0"
Review comment:
@ibzib Comparing the lines added here with what's available in
BeamModulePlugin and my proposed plan to use what's available where possible:
- com.google.api.grpc:proto-google-cloud-bigquerystorage-v1 is not available
- as you pointed out.
- com.google.api.grpc:proto-google-cloud-bigtable-admin-v2 is not available
- com.google.api.grpc:proto-google-cloud-spanner-v1 is not available
- com.google.api:api-common *is available* - but the version coming in from
google_cloud_platform_libraries_bom is unclear to me. **Replacing**.
- com.google.apis:google-api-services-storage is a match. **Replacing**.
- com.google.code.gson:gson:2.8.6 is a match. **Replacing**.
- com.google.errorprone:error_prone_annotations is 2.3.3 here, but 2.3.1 in
BeamModulePlugin. **Skipping**, but putting in a TODO in the code to match
version numbers.
- com.google.protobuf:protobuf-java-util is 3.11.1 here, but 3.12.0 in
BeamModulePlugin. **Skipping**, but putting in a TODO in the code to match
version numbers.
- io.grpc:grpc-api *is available* - but the version coming in from
google_cloud_platform_libraries_bom is unclear to me. **Replacing**.
- org.apache.beam:beam-vendor-guava-26_0-jre is available. ** Replacing**.
- org.apache.httpcomponents:httpclient is 4.5.12 here, but 4.5.10 in
BeamModulePlugin. **Skipping** but putting in a TODO in the code to match
version numbers.
- org.apache.httpcomponents:httpcore is 4.4.13 here, but 4.4.12 in
BeamModulePlugin. ** Skipping** but putting in a TODO in the code to match
version numbers.
- org.hamcrest:hamcrest is not available in BeamModulePlugin
- org.threethen:threetenbp is not available in BeamModulePlugin
- compile "org.apache.beam:beam-vendor-grpc-1_26_0:0.3" is available.
**Replacing**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
