ibzib commented on a change in pull request #13791:
URL: https://github.com/apache/beam/pull/13791#discussion_r565750792
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -50,50 +50,54 @@ dependencies {
exclude group: 'io.grpc', module: 'grpc-grpclb'
}
compile library.java.google_cloud_core
- compile(library.java.google_cloud_core_grpc) {
- exclude group: 'io.grpc', module: 'grpc-core' // Use Beam's version
- }
compile library.java.google_cloud_datastore_v1_proto_client
compile library.java.google_cloud_pubsublite
// GCP PubSub client is used in TestPubSub
compile library.java.google_cloud_pubsub
compile library.java.google_cloud_spanner
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
- compile library.java.grpc_alts
compile library.java.grpc_auth
- compile library.java.grpc_core
- compile library.java.grpc_context
- compile library.java.grpc_grpclb
+ testImplementation 'io.grpc:grpc-core:1.27.2'
compile library.java.grpc_netty
- compile library.java.grpc_netty_shaded
- compile library.java.grpc_stub
compile library.java.grpc_google_cloud_pubsub_v1
- compile library.java.grpc_google_cloud_pubsublite_v1
compile library.java.guava
- compile library.java.hamcrest_core
compile library.java.jackson_databind
compile library.java.joda_time
compile library.java.junit
compile library.java.netty_handler
- compile library.java.netty_tcnative_boringssl_static
- compile library.java.proto_google_cloud_bigquery_storage_v1beta1
compile library.java.proto_google_cloud_bigtable_v2
compile library.java.proto_google_cloud_datastore_v1
compile library.java.proto_google_cloud_pubsub_v1
compile library.java.proto_google_cloud_pubsublite_v1
- compile library.java.proto_google_cloud_spanner_admin_database_v1
compile library.java.proto_google_common_protos
compile library.java.protobuf_java
compile library.java.slf4j_api
+ compile "com.google.api.grpc:proto-google-cloud-bigquerystorage-v1:0.90.0"
Review comment:
> the version coming in from google_cloud_platform_libraries_bom is
unclear to me.
That's totally fine. The whole point of using the bom is that it provides a
single source of truth for dependency versions. If the version provided by the
bom mismatches some version the build is actually using, it's a problem.
> org.hamcrest:hamcrest is not available in BeamModulePlugin
I've seen this one in enough other modules that it probably should be placed
in BeamModulePlugin.
> Skipping, but putting in a TODO in the code to match version numbers.
Try replacing these anyway, don't worry about matching the versions exactly.
In most cases I expect that it shouldn't matter if we use a slightly newer or
older version than one of the transitive dependencies, as long as the versions
are compatible. (If we don't match versions, Gradle will do that for us anyway
when it [resolves
dependencies](https://docs.gradle.org/current/userguide/dependency_resolution.html).)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
