amaliujia commented on a change in pull request #13835:
URL: https://github.com/apache/beam/pull/13835#discussion_r566563951
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/JavaUdfLoader.java
##########
@@ -57,7 +58,10 @@
* Maps the external jar location to the functions the jar defines. Static
so it can persist
* across multiple SQL transforms.
*/
- private static final Map<String, FunctionDefinitions> cache = new
HashMap<>();
+ private static final Map<String, FunctionDefinitions> functionCache = new
HashMap<>();
+
+ /** Maps potentially remote jar paths to their local file copies. */
+ private static final Map<String, File> jarCache = new HashMap<>();
Review comment:
I see.
I see there are IOException thrown when loading jars. As long as there are
meaningful exception are caught, at least we will have exceptions in log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
