amaliujia commented on a change in pull request #13835:
URL: https://github.com/apache/beam/pull/13835#discussion_r566564863
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java
##########
@@ -274,6 +298,25 @@ public void processElement(ProcessContext c) {
}
}
+ private static List<String> getJarPaths(RexProgram program) {
+ List<String> jarPaths = new ArrayList<>();
+ for (RexNode node : program.getExprList()) {
+ if (node instanceof RexCall) {
+ SqlOperator op = ((RexCall) node).op;
Review comment:
Nit: I am not sure whether there will be nested call case here (i.e. one
of the operands are actually a RexCall). If there is, maybe add a TODO or a
check for such case.
We don't need to handle nested call in this PR. The solution for that will
be complicated.
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java
##########
@@ -274,6 +298,25 @@ public void processElement(ProcessContext c) {
}
}
+ private static List<String> getJarPaths(RexProgram program) {
+ List<String> jarPaths = new ArrayList<>();
+ for (RexNode node : program.getExprList()) {
+ if (node instanceof RexCall) {
+ SqlOperator op = ((RexCall) node).op;
Review comment:
Nit: I am not sure whether there could be nested call case here (i.e.
one of the operands are actually a RexCall). If there is, maybe add a TODO or a
check for such case.
We don't need to handle nested call in this PR. The solution for that will
be complicated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
