TheNeuralBit commented on a change in pull request #13596:
URL: https://github.com/apache/beam/pull/13596#discussion_r568762562
##########
File path: website/www/site/layouts/index.html
##########
@@ -63,73 +61,105 @@ <h2 class="pillars-title">
{{ end }}
{{ define "graphic-section" }}
- <div class="graphic section">
- <div class="graphic__image">
- <img src="/images/beam_architecture.png" alt="Beam architecture">
+ <div class="graphic">
+ <div class="quotes">
+ <h2 class="margin">{{ T "home-model-title1" }}</h2>
+ <div class="margin section">
+ <div class="row images desktop">
+ <img src="/images/model-sources-icon.svg" class='icon'/>
+ <img src="/images/model-ellipse.svg"/>
+ <img src="/images/model-processing-icon.svg" class='icon'/>
+ <img src="/images/model-ellipse.svg"/>
+ <img src="/images/model-sinks-icon.svg" class='icon'/>
+ </div>
+ <div class="row">
+ {{ $data := index $.Site.Data .Site.Language.Lang }}
+ {{ range $item := $data.graphic }}
+ <div class="column">
+ <img src="{{ .icon }}" class='icon mobile'/>
+ <h4>{{ .title }}</h4>
+ <p>{{ .body }}</p>
+ </div>
+ {{ end }}
+ </div>
+ </div>
+ </div>
+ <div class="section">
+ <h2 class="margin">{{ T "home-model-title2" }}</h2>
+ <div class="row margin">
+ <div class="column">
+ <div class="logos-row">
+ <img src="/images/logos/runners/gray-logos-1.svg"/>
+ </div>
+ <p class="more">{{ T "home-graphic-more" }}</p>
+ <div>
+ <h4>{{ T "home-graphic-runner-title" }}</h4>
+ <p>{{ T "home-graphic-runner-body" }}</p>
+ </div>
+ </div>
+ <div class="column">
+ <div class="logos-row">
+ <img class="first_logo" src="/images/logos/sdks/python-gray.svg"/>
+ <img src="/images/logos/sdks/java-gray.svg"/>
+ </div>
+ <p class="more">{{ T "home-graphic-more" }}</p>
+ <div>
+ <h4>{{ T "home-graphic-language-title" }}</h4>
+ <p>{{ T "home-graphic-language-body" }}</p>
+ </div>
+ </div>
+ </div>
</div>
</div>
{{ end }}
-{{/*
- TODO:
- This is the implementation of the design.
- The event sync functionality will be implemented when we have the event
page.
-*/}}
{{ define "calendar-section" }}
<div class="calendar">
<h2 class="calendar-title">
{{ T "home-calendar-title" }}
</h2>
<div class="calendar-content">
- <a href="#">
- <div class="calendar-card-big calendar-card-big-left">
- <div class="calendar-category">
- <p class="calendar-category-tag">{{ T
"home-calendar-category-tag-first" }}</p>
- <p class="calendar-category-date">{{ T
"home-calendar-category-date-first" }}</p>
- </div>
- <h4 class="calendar-card-big-title">
- {{ T "home-calendar-card-title-first" }}
- </h4>
- <p class="calendar-card-author">{{ T
"home-calendar-card-author-first" }}</p>
+ <div class="calendar-card-big calendar-card-big-left">
+ <div class="desktop">
+ <a class="twitter-timeline" data-width="381" data-height="460"
href="https://twitter.com/ApacheBeam?ref_src=twsrc%5Etfw";>Tweets by
ApacheBeam</a>
</div>
- </a>
+ <div class="mobile">
+ <a class="twitter-timeline" data-width="381" data-height="348"
href="https://twitter.com/ApacheBeam?ref_src=twsrc%5Etfw";>Tweets by
ApacheBeam</a>
+ </div>
+ </div>
<div class="calendar-card-box">
- <a href="#">
- <div class="calendar-card-small">
- <div class="calendar-category">
- <p class="calendar-category-tag">{{ T
"home-calendar-category-tag-second" }}</p>
- <p class="calendar-category-date">{{ T
"home-calendar-category-date-second" }}</p>
+ {{ range first 2 (after 1 (where .Site.Pages.ByPublishDate.Reverse
"Section" "blog")) }}
+ <a class="post-card" href="{{ .RelPermalink }}"
data-categories="{{ with .Params.categories }}{{ if eq ( printf "%T" . )
"string" }}{{ . | replaceRE "[.]" "_" | urlize }}{{ else if eq ( printf "%T" .
) "[]string" }}{{ range . }}{{ . | replaceRE "[.]" "_" | urlize }}
{{end}}{{end}}{{else}}no-author{{end}}"
+ >
+ <div class="post-info post-category">
+ <p>
+ {{ if .Params.categories }}
+ {{ delimit .Params.categories ", " " & " }}
+ {{ end }}
+ </p>
+ <p>{{ .Date.Format "2006/01/02" }}</p>
+ </div>
+ <div>
+ <p class="post-title">{{ .Title }}</p>
+ <p class="post-info">
+ {{ if .Params.authors }}
+ {{ delimit .Params.authors ", " " & " }}
+ {{ end }}
Review comment:
Thank you, this is much better!
I noticed another issue around this though, in the "Latest from the blog"
section we're attributing the blog posts to the author of _this_ post, rather
than the authors of the linked post:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
