TheNeuralBit commented on a change in pull request #13596:
URL: https://github.com/apache/beam/pull/13596#discussion_r569548451
##########
File path: website/www/site/layouts/shortcodes/documentation/runners.html
##########
@@ -0,0 +1,45 @@
+{{/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
+ */}}
+
+ {{ $data := index $.Site.Data .Site.Language.Lang }}
+ <div class="documentation-list mobile-column">
+ {{ range first 6 ($item := $data.documentation_runners) }}
+ {{ if .icon }}
+ {{ partial "documentation/icon-row" (dict "logo" .icon
"header" .name "text" .description) }}
+ {{ else }}
+ {{ partial "documentation/icon-row" (dict "header" .name
"text" .description) }}
+ {{ end }}
+ {{ end }} </div>
+ {{ if gt (len $data.documentation_runners) 6 }}
+ <div class="collapsable-list">
+ <div class="collapse" id="collapseRunners">
+ <ul>
+ {{ range last 2 ($item := $data.documentation_runners) }}
+ <li><a href={{.name.link}} >{{ .name.text}}</a> {{
.description | safeHTML }}</li>
+ {{ end }}
+ </ul>
+ </div>
+ <a data-toggle="collapse" href="#collapseRunners" role="button"
aria-expanded="false" aria-controls="collapseExample" id="collapse-button"
onclick="changeText()">
+ + SHOW MORE
Review comment:
A couple comments on the way the runners table renders on desktop:
- [ ] It's odd that there's a row of 4 and then a row of 2. Is that
intentional? I'd expect it to be 3 and 3.
- [ ] This "show more" doesn't seem to work correctly on desktop. Note in
the screenshot above that extra runners are still visible even though "show
more" isn't clicked. Toggling the button has no effect. When I switch to mobile
view it does seems to work as intended.
##########
File path: website/www/site/content/en/documentation/_index.md
##########
@@ -40,24 +41,15 @@ Learn about the Beam Programming Model and the concepts
common to all Beam SDKs
Review comment:
The links in the Concepts and Pipeline Fundamentals sections (above) are
hidden:
You can't tell they're links until you happen to hover over them. Is this
something wrong with the CSS?
##########
File path: website/www/site/layouts/blog/single.html
##########
@@ -12,26 +12,73 @@
{{ define "main" }}
{{ $authors := .Params.authors }}
+ {{ $data := index $.Site.Data.authors }}
<article class="post" itemscope itemtype="http://schema.org/BlogPosting";>
-
+ <div class="post-content">
+ <div class="post-info">
+ <p>
+ {{ delimit .Params.categories ", " " & " }}
+ </p>
+ <p>{{ .Date.Format "2006/01/02" }}</p>
+ </div>
<header class="post-header">
- <h1 class="post-title" itemprop="name headline">{{ .Title }}</h1>
- <p class="post-meta"><time datetime="{{ .Date.Format
"2006-01-02T15:04:05Z07:00" }}" itemprop="datePublished">{{ .Date.Format "Jan
2, 2006" }}</time>
- {{ with $authors }} •
- {{ $count := len . }}
- {{ range $index, $authorId := . }}
- {{ if not (isset $.Site.Data.authors $authorId) }} {{ errorf
"Author '%s' is not defined. Please add them to
'website/www/site/data/authors.yml'" $authorId }} {{end}}
Review comment:
Could you keep this check? It makes sure the website build fails when a
new blog post author hasn't added their information.
##########
File path: website/www/site/layouts/shortcodes/documentation/sdks.html
##########
@@ -0,0 +1,18 @@
+{{/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
+ */}}
+
+ {{ $data := index $.Site.Data .Site.Language.Lang }}
+ <div class="documentation-list">
+ {{ range $item := $data.documentation_sdks }}
+ {{ partial "documentation/icon-row" (dict "logo" .icon "header" .name
"text" .description) }}
+ {{ end }}
Review comment:
The icons aren't showing up for the SDKs for me:
I can't figure out why the icons are working for the runners and not the
SDKs, do you know?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
