TheNeuralBit commented on a change in pull request #13596:
URL: https://github.com/apache/beam/pull/13596#discussion_r569548451
##########
File path: website/www/site/layouts/shortcodes/documentation/runners.html
##########
@@ -0,0 +1,45 @@
+{{/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
+ */}}
+
+ {{ $data := index $.Site.Data .Site.Language.Lang }}
+ <div class="documentation-list mobile-column">
+ {{ range first 6 ($item := $data.documentation_runners) }}
+ {{ if .icon }}
+ {{ partial "documentation/icon-row" (dict "logo" .icon
"header" .name "text" .description) }}
+ {{ else }}
+ {{ partial "documentation/icon-row" (dict "header" .name
"text" .description) }}
+ {{ end }}
+ {{ end }} </div>
+ {{ if gt (len $data.documentation_runners) 6 }}
+ <div class="collapsable-list">
+ <div class="collapse" id="collapseRunners">
+ <ul>
+ {{ range last 2 ($item := $data.documentation_runners) }}
+ <li><a href={{.name.link}} >{{ .name.text}}</a> {{
.description | safeHTML }}</li>
+ {{ end }}
+ </ul>
+ </div>
+ <a data-toggle="collapse" href="#collapseRunners" role="button"
aria-expanded="false" aria-controls="collapseExample" id="collapse-button"
onclick="changeText()">
+ + SHOW MORE
Review comment:
A couple comments on the way the runners table renders on desktop:
- [x] It's odd that there's a row of 4 and then a row of 2. Is that
intentional? I'd expect it to be 3 and 3.
- [x] This "show more" doesn't seem to work correctly on desktop. Note in
the screenshot above that extra runners are still visible even though "show
more" isn't clicked. Toggling the button has no effect. When I switch to mobile
view it does seems to work as intended.
- [x] It looks like the icons are left justified, they might look better
centered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
