apilloud commented on pull request #13898: URL: https://github.com/apache/beam/pull/13898#issuecomment-776922290
That isn't entirely true. Literals are stored as a BigDecimal (which is what was disabled): https://github.com/apache/beam/blob/9bbd5bd514efdbd68ac903ec416882b3cccceb2b/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlCalciteTranslationUtils.java#L211 The generated code prints the literal to a string and looks like this: `c.output(org.apache.beam.sdk.values.Row.withSchema(outputSchema).attachValues(java.util.Arrays.asList(new org.apache.beam.sdk.extensions. sql.provider.UdfTestProvider.IncrementFn().increment(5L))));` In earlier testing I was seeing overflow errors from gRPC, but that appears to actually be caused by DOUBLE literals (which are also stored as BigDecimal). I've added DECIMAL to the list of allowed types for literals and reverted the test changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
