ibzib commented on a change in pull request #13898:
URL: https://github.com/apache/beam/pull/13898#discussion_r577275001
##########
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlJavaUdfTest.java
##########
@@ -222,13 +224,18 @@ public void testBinaryJavaUdf() {
String sql =
String.format(
"CREATE FUNCTION matches(str STRING, regStr STRING) RETURNS
BOOLEAN LANGUAGE java OPTIONS (path='%s'); "
- + "SELECT matches(\"a\", \"a\"), 'apple'='beta'",
+ + "SELECT matches('a', 'a'), matches('apple', 'beta')",
Review comment:
Currently, this tests what happens when we mix UDFs and builtin
operators. We should probably keep this coverage (maybe change `matches` to
`helloWorld` for simplicity) and make `testBinaryJavaUdf` a separate test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
