kennknowles commented on a change in pull request #13998:
URL: https://github.com/apache/beam/pull/13998#discussion_r577326177
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/InvalidWindows.java
##########
@@ -87,4 +87,9 @@ public void verifyCompatibility(WindowFn<?, ?> other) throws
IncompatibleWindowE
public Instant getOutputTime(Instant inputTimestamp, W window) {
return inputTimestamp;
}
+
+ @Override
+ public boolean isNonMerging() {
Review comment:
It might be even better to change to `extends NonMergingWindowFn`.
I also think: wow! we chose the wrong default value for this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
