kennknowles commented on pull request #13998: URL: https://github.com/apache/beam/pull/13998#issuecomment-780314218
To be clear: we should fix the CI signal, but I think best to sickbay the test until this is sorted out. Probably the right thing for `InvalidWindows` to do is to delegate `isNonMerging` to the original windowFn. But at runtime the right thing for it to do is to crash! So we don't want to fix the crash, but figure out why it was being called. The tests exists specifically to catch the failure that has occurred. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
