apilloud commented on pull request #13898:
URL: https://github.com/apache/beam/pull/13898#issuecomment-780769137
@amaliujia One example is `SELECT CAST
(Double(179769313486231570814527423731704356798070567525844996598917476803157260780028538760589558632766878171540458953514382464234321326889464182768467546703537516986049910576551282076245490090389328944075868508455133942304583236903222948165808559332123348274797826204144723168738177180919299881250404026184124858368)
AS NUMERIC) AS ColA` It generates this code:
```
{
final java.math.BigDecimal v = new java.math.BigDecimal(
"179769313486231570814527423731704356798070567525844996598917476803157260780028538760589558632766878171540458953514382464234321326889464182768467546703537516986049910576551282076245490090389328944075868508455133942304583236903222948165808559332123348274797826204144723168738177180919299881250404026184124858368");
c.output(org.apache.beam.sdk.values.Row.withSchema(outputSchema).attachValues(java.util.Arrays.asList(v)));
}
```
This fixes at least 9 additional data corruption bugs (mostly around
timestamps) and doesn't break any tests in Beam. I can provide you the link to
the internal run of this, but if you want to debate further I would suggest we
roll back first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
