y1chi commented on a change in pull request #14120:
URL: https://github.com/apache/beam/pull/14120#discussion_r592805378
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkPartialReduceFunction.java
##########
@@ -98,11 +98,10 @@ public void combine(
if (groupedByWindow) {
reduceRunner = new SingleWindowFlinkCombineRunner<>();
} else {
- if (windowingStrategy.needsMerge()
- &&
!windowingStrategy.getWindowFn().windowCoder().equals(IntervalWindow.getCoder()))
{
- reduceRunner = new HashingFlinkCombineRunner<>();
- } else {
+ if (windowingStrategy.needsMerge() && windowingStrategy.getWindowFn()
instanceof Sessions) {
Review comment:
I think so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
