y1chi commented on a change in pull request #14120:
URL: https://github.com/apache/beam/pull/14120#discussion_r592807963
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkMergingNonShuffleReduceFunction.java
##########
@@ -83,7 +83,7 @@ public void reduce(
new FlinkSideInputReader(sideInputs, getRuntimeContext());
AbstractFlinkCombineRunner<K, InputT, AccumT, OutputT, W> reduceRunner;
- if
(windowingStrategy.getWindowFn().windowCoder().equals(IntervalWindow.getCoder()))
{
+ if (windowingStrategy.needsMerge() && windowingStrategy.getWindowFn()
instanceof Sessions) {
Review comment:
yeah, looks like FlinkMergingNonShuffleReduceFunction is only used when
the status is
needsMerge.https://github.com/apache/beam/blob/master/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchTransformTranslators.java#L593.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
