nehsyc commented on a change in pull request #14164:
URL: https://github.com/apache/beam/pull/14164#discussion_r595710982
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java
##########
@@ -133,7 +139,14 @@
// We could consider making this a parameter.
private static final int SPILLED_RECORD_SHARDING_FACTOR = 10;
+ // The record count and buffering duration to trigger flushing records to a
tmp file. Mainly used
+ // for writing unbounded data to avoid generating too many small files.
+ private static final int FILE_TRIGGERING_RECORD_COUNT = 10000;
+ private static final Duration FILE_TRIGGERING_RECORD_BUFFERING_DURATION =
+ Duration.standardSeconds(1);
Review comment:
These values are rather random :\ Let me know if you have insights of
what values would be more proper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
