nehsyc commented on pull request #14164: URL: https://github.com/apache/beam/pull/14164#issuecomment-805148216
@chamikaramj Hey Cham, I uploaded a new commit. You are right about the risk of changing `Reshuffle` to `GBK` since rewindowing would be needed if using session windows. The new code path for auto-sharding however needs a true `GBK` to gather temp file results in the same window. The current implementation does not yet work with session windows and I'd like to do that in a separate PR. Could you take a pass again to see if everything makes sense to you now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
