amaliujia commented on a change in pull request #14265:
URL: https://github.com/apache/beam/pull/14265#discussion_r597930454
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -89,7 +89,9 @@
public class ZetaSQLQueryPlanner implements QueryPlanner {
// TODO(BEAM-11747) Re-enable BeamJavaUdfCalcRule by default when it is safe
to do so.
public static final Collection<RelOptRule> DEFAULT_CALC =
-
ImmutableList.<RelOptRule>builder().add(BeamZetaSqlCalcRule.INSTANCE).build();
+ ImmutableList.<RelOptRule>builder()
+ .add(BeamZetaSqlCalcRule.INSTANCE, BeamZetaSqlCalcMergeRule.INSTANCE)
Review comment:
Will it make sense to create two RuleSets? One for each dialect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
