ibzib commented on pull request #14265: URL: https://github.com/apache/beam/pull/14265#issuecomment-803076461
> Is there a testing plan for this change (maybe in following PRs)? Checking for an exact query plan is somewhat brittle, but I guess we should have some tests to alert us when the plan changes. FWIW I noticed that when I disabled the merge rules, some existing tests did break. https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLPushDownTest.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
