suztomo commented on pull request #14348:
URL: https://github.com/apache/beam/pull/14348#issuecomment-809437658
grpc-netty's ServerFactory calls addServie on NettyServerBuilder. It doesn't
implement addService method but it inherits addService from
AbstractServerImplBuilder in grpc-core. grpc-core:1.33.1 has this addService
implementation.
```
public T addService(ServerServiceDefinition service) {
this.delegate().addService(service);
return this.thisT();
}
```
This is a typical builder pattern. Spotbugs should not report this as a
method without a side effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
