TheNeuralBit commented on pull request #14350: URL: https://github.com/apache/beam/pull/14350#issuecomment-812232598
I took a look at the PostCommit failure (`BigQueryNestedRecordsIT.testNestedRecords`), it's another case where the expected result contains doubles, and now we're producing strings. However in this case we're using `BigqueryClient` to read the expected value directly, and it's producing the value that contains doubles. It looks like BigqueryClient actually already has logic to convert the Strings we get from BQ into booleans and doubles: https://github.com/apache/beam/blob/5ddb69f4bd9fc281c3f401fee87232163ee09ba9/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/BigqueryClient.java#L258-L259 (CC: @pabloem since it looks like you added this logic) So maybe your [original approach](https://github.com/mouyang/beam/commit/326b291ab333c719a9f54446c34611581ea696eb) is actually correct? If that's the case I would expect reading beam rows to fail with JSON as well as Avro, is there a test for that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
