ibzib commented on a change in pull request #14437:
URL: https://github.com/apache/beam/pull/14437#discussion_r607395276
##########
File path: sdks/python/apache_beam/runners/interactive/utils.py
##########
@@ -205,7 +207,9 @@ def __enter__(self):
else:
display(self._enter_text)
except ImportError:
- pass # NOOP when dependencies are not available.
+ _LOGGER.warning(
Review comment:
It'd be helpful to log the ImportError here as well.
##########
File path: sdks/python/apache_beam/runners/interactive/utils_test.py
##########
@@ -182,6 +183,9 @@ def
test_child_module_logger_can_override_logging_level(self, mock_emit):
@unittest.skipIf(
not ie.current_env().is_interactive_ready,
'[interactive] dependency is not installed.')
[email protected](
Review comment:
Why do we need to skip this test (as opposed to failing) if
[interactive] is not installed? I'm worried that if the build changes and
[interactive] is never installed, we will silently drop test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
