KevinGG commented on a change in pull request #14437:
URL: https://github.com/apache/beam/pull/14437#discussion_r607435769
##########
File path: sdks/python/apache_beam/runners/interactive/utils_test.py
##########
@@ -182,6 +183,9 @@ def
test_child_module_logger_can_override_logging_level(self, mock_emit):
@unittest.skipIf(
not ie.current_env().is_interactive_ready,
'[interactive] dependency is not installed.')
[email protected](
Review comment:
The tests are skipped for tox environments that does not have
interactive dependencies installed. Similar to [gcp], [aws] and etc. Because
not all test suites and their test environment has/need all the dependencies
installed. These are intentionally skipped.
My worry is that there might be some rare cases that some dependency is not
installed correctly and pytest does not skip the test but error out.
I also just mocked out the ie.current_env to gain more stability. It seems
that it is the root cause of the flakiness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
