InigoSJ commented on a change in pull request #14446:
URL: https://github.com/apache/beam/pull/14446#discussion_r608055135
##########
File path: sdks/python/apache_beam/utils/timestamp.py
##########
@@ -66,6 +66,7 @@ def __init__(self, seconds=0, micros=0):
raise TypeError(
'Cannot interpret %s %s as micros.' % (micros, type(micros)))
self.micros = int(seconds * 1000000) + int(micros)
+ self.seconds = seconds + micros / 1000000
Review comment:
Good point, I was considering using the `@property` and a
`_get_seconds()`. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
