aaltay commented on a change in pull request #14446:
URL: https://github.com/apache/beam/pull/14446#discussion_r608809368
##########
File path: sdks/python/apache_beam/transforms/periodicsequence.py
##########
@@ -81,6 +86,9 @@ def process(
'''
start, _, interval = element
+ if isinstance(start, Timestamp):
Review comment:
Not directly related to your change. But this code has some other issues.
`current_output_timestamp` is not a Timestamp and needs to be converted
later.
mixed use of Timestamp and timestamp.Timestamp - we can pick either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
