rohdesamuel commented on a change in pull request #14362:
URL: https://github.com/apache/beam/pull/14362#discussion_r608967945



##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -2164,6 +2186,20 @@ def __init__(self, frame):
   def names(self):
     return self._frame._expr.proxy().index.names
 
+  @names.setter
+  def names(self, value):
+    def set_index_names(df):
+      df = df.copy()
+      df.index.names = value
+      return df

Review comment:
       Out of curiosity, why the copy here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to