rohdesamuel commented on a change in pull request #14362:
URL: https://github.com/apache/beam/pull/14362#discussion_r608974423
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -486,11 +486,35 @@ def _get_index(self):
first = last = frame_base.wont_implement_method('order-sensitive')
head = tail = frame_base.wont_implement_method('order-sensitive')
+ interpolate = frame_base.wont_implement_method('order-sensitive')
@populate_not_implemented(pd.Series)
@frame_base.DeferredFrame._register_for(pd.Series)
class DeferredSeries(DeferredDataFrameOrSeries):
+ @property
+ def name(self):
+ return self._expr.proxy().name
Review comment:
Another implementation question: does the return proxy() change over
this DeferredSeries lifetime?
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -486,11 +486,35 @@ def _get_index(self):
first = last = frame_base.wont_implement_method('order-sensitive')
head = tail = frame_base.wont_implement_method('order-sensitive')
+ interpolate = frame_base.wont_implement_method('order-sensitive')
@populate_not_implemented(pd.Series)
@frame_base.DeferredFrame._register_for(pd.Series)
class DeferredSeries(DeferredDataFrameOrSeries):
+ @property
+ def name(self):
+ return self._expr.proxy().name
Review comment:
Another implementation question: does the return of proxy() change over
this DeferredSeries lifetime?
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -486,11 +486,35 @@ def _get_index(self):
first = last = frame_base.wont_implement_method('order-sensitive')
head = tail = frame_base.wont_implement_method('order-sensitive')
+ interpolate = frame_base.wont_implement_method('order-sensitive')
@populate_not_implemented(pd.Series)
@frame_base.DeferredFrame._register_for(pd.Series)
class DeferredSeries(DeferredDataFrameOrSeries):
+ @property
+ def name(self):
+ return self._expr.proxy().name
Review comment:
Another implementation question: does the return value of proxy() change
over this DeferredSeries lifetime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
